fixing generics

rodydavis · Nov 27, 2023 · b12f77b · b12f77b
1 parent 93af97b
commit b12f77b
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 12 deletions.
diff --git a/packages/flutter_preact_signals/CHANGELOG.md b/packages/flutter_preact_signals/CHANGELOG.md
@@ -1,4 +1,8 @@
-## 0.2.1
+## 0.3.1
+
+- Updating `preact_signals` to 0.3.1
+
+## 0.3.0
 
 - Fixing `watchSignal` so it works in StatefulWidgets and inside rebuilds and subscriber list will remain stable
 - Updating example to show non global signal

diff --git a/packages/flutter_preact_signals/pubspec.yaml b/packages/flutter_preact_signals/pubspec.yaml
@@ -10,7 +10,7 @@ environment:
 dependencies:
   flutter:
     sdk: flutter
-  preact_signals: ^0.3.0
+  preact_signals: ^0.3.1
 
 dev_dependencies:
   flutter_test:

diff --git a/packages/preact_signals/CHANGELOG.md b/packages/preact_signals/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.3.1
+
+- Fixing generics for `FutureSignal`, `StreamSignal`, `IterableSignal`, `ListSignal`, `MapSignal` and `SetSignal`
+
 ## 0.3.0
 
 - Adding value signals: `ListSignal`, `MapSignal`, `SetSignal`, `IterableSignal`

diff --git a/packages/preact_signals/lib/src/extensions/future.dart b/packages/preact_signals/lib/src/extensions/future.dart
@@ -1,7 +1,7 @@
 import 'package:preact_signals/src/future_signal.dart';
 
 /// Extension on future to provide helpful methods for signals
-extension SignalFutureUtils on Future {
+extension SignalFutureUtils<T> on Future<T> {
   /// Convert an existing future to [FutureSignal]
   ///
   /// ```dart
@@ -23,8 +23,8 @@ extension SignalFutureUtils on Future {
   ///   SignalLoading _ => print('loading'),
   /// });
   /// ```
-  FutureSignal toSignal({Duration? timeout}) {
-    return FutureSignal(
+  FutureSignal<T> toSignal({Duration? timeout}) {
+    return FutureSignal<T>(
       () => this,
       timeout: timeout,
     );

diff --git a/packages/preact_signals/lib/src/extensions/iterable.dart b/packages/preact_signals/lib/src/extensions/iterable.dart
@@ -4,6 +4,6 @@ import 'package:preact_signals/src/iterable_signal.dart';
 extension SignalIterableUtils<T> on Iterable<T> {
   /// Convert an existing list to [IterableSignal]
   IterableSignal<T> toSignal() {
-    return IterableSignal(this);
+    return IterableSignal<T>(this);
   }
 }
diff --git a/packages/preact_signals/lib/src/extensions/list.dart b/packages/preact_signals/lib/src/extensions/list.dart
@@ -4,6 +4,6 @@ import 'package:preact_signals/src/list_signal.dart';
 extension SignalListUtils<T> on List<T> {
   /// Convert an existing list to [ListSignal]
   ListSignal<T> toSignal() {
-    return ListSignal(this);
+    return ListSignal<T>(this);
   }
 }
diff --git a/packages/preact_signals/lib/src/extensions/map.dart b/packages/preact_signals/lib/src/extensions/map.dart
@@ -4,6 +4,6 @@ import 'package:preact_signals/src/map_signal.dart';
 extension SignalMapUtils<K, V> on Map<K, V> {
   /// Convert an existing list to [MapSignal]
   MapSignal<K, V> toSignal() {
-    return MapSignal(this);
+    return MapSignal<K, V>(this);
   }
 }
diff --git a/packages/preact_signals/lib/src/extensions/stream.dart b/packages/preact_signals/lib/src/extensions/stream.dart
@@ -1,7 +1,5 @@
 import 'package:preact_signals/preact_signals.dart';
 
-import '../stream_signal.dart';
-
 /// Extension on stream to provide helpful methods for signals
 extension SignalStreamUtils<T> on Stream<T> {
   /// Convert a stream to a signal
@@ -17,7 +15,7 @@ extension SignalStreamUtils<T> on Stream<T> {
   /// final stream = createStream();
   /// final signal = stream.toSignal();
   /// ```
-  /// 
+  ///
   /// The [StreamSignal] will return [SignalState] for the value. To react to
   /// the various states you can use a switch statement:
   ///

diff --git a/packages/preact_signals/pubspec.yaml b/packages/preact_signals/pubspec.yaml
@@ -1,6 +1,6 @@
 name: preact_signals
 description: Signal, Computed and Effect built with dart
-version: 0.3.0
+version: 0.3.1
 repository: https://github.com/rodydavis/preact_signals.dart
 
 environment: