fix(test): test local config last, since it has side effects

g2p/tests/run.py

@@ -25,6 +25,7 @@
 from g2p.tests.test_transducer import TransducerTest
 from g2p.tests.test_unidecode_transducer import UnidecodeTransducerTest
 from g2p.tests.test_utils import UtilsTest
+from g2p.tests.test_z_local_config import LocalConfigTest
 
 # Deliberately left out:
 # from g2p.tests.test_doctor_expensive import ExpensiveDoctorTest
@@ -66,21 +67,29 @@
     ]
 ]
 
-DEV_TESTS = TRANSDUCER_TESTS + MAPPINGS_TESTS + LANGS_TESTS + INTEGRATION_TESTS
+# LocalConfigTest has to get run last, to avoid interactions with other test
+# cases, since it has side effects on the global database
+LAST_DEV_TEST = [
+    LOADER.loadTestsFromTestCase(test) for test in [
+        LocalConfigTest,
+    ]
+]
+
+DEV_TESTS = TRANSDUCER_TESTS + MAPPINGS_TESTS + LANGS_TESTS + INTEGRATION_TESTS + LAST_DEV_TEST
 
 
 def run_tests(suite):
     ''' Decide which Test Suite to run
     '''
     if suite == 'all':
         suite = LOADER.discover(os.path.dirname(__file__))
-    if suite == 'trans':
+    elif suite == 'trans':
         suite = TestSuite(TRANSDUCER_TESTS)
-    if suite == 'langs':
+    elif suite == 'langs':
         suite = TestSuite(LANGS_TESTS)
-    if suite == 'mappings':
+    elif suite == 'mappings':
         suite = TestSuite(MAPPINGS_TESTS)
-    if suite == 'integ':
+    elif suite == 'integ':
         suite = TestSuite(INTEGRATION_TESTS)
     elif suite == 'dev':
         suite = TestSuite(DEV_TESTS)
@@ -89,7 +98,7 @@ def run_tests(suite):
         LOGGER.error("Please specify a test suite to run: i.e. 'dev' or 'all'")
     else:
         return runner.run(suite)
-    
+
 
 
 if __name__ == "__main__":

g2p/tests/test_cli.py

@@ -9,7 +9,6 @@
 from g2p.app import APP
 from g2p.cli import convert, doctor, generate_mapping, scan, update
 from g2p.log import LOGGER
-from g2p.tests.public import PUBLIC_DIR
 from g2p.tests.public.data import __file__ as data_dir
 
 
@@ -225,18 +224,6 @@ def test_generate_mapping_errors(self):
             "Non-existent out-dir must be reported as error",
         )
 
-    def test_local_config(self):
-        config_path = os.path.join(PUBLIC_DIR, "mappings", "test.yaml")
-        result = self.runner.invoke(
-            convert,
-            ["bbbb", "local-config-in", "local-config-out", "--config", config_path,],
-        )
-        self.assertIn("aaaa", result.stdout)
-        result = self.runner.invoke(
-            convert, ["b", "local-config-in", "eng-ipa", "--config", config_path,],
-        )
-        self.assertIn("ɑ", result.stdout)
-
 
 if __name__ == "__main__":
     main()

g2p/tests/test_z_local_config.py

@@ -0,0 +1,40 @@
+#!/usr/bin/env python3
+
+"""
+Test that the --config switch to g2p convert works
+
+This test modifies the g2p database in memory, so it's important that it get
+run last, in order to avoid changing the results of other unit test cases.
+
+We accomplish that in two ways:
+ - in "./run.py dev", it gets appended after all the other tests, explicitly.
+ - the file name has a "z" so it sorts last when "./run.py all" uses LOADER.discover()
+"""
+
+from unittest import main, TestCase
+import os
+
+from g2p.app import APP
+from g2p.cli import convert
+from g2p.tests.public import PUBLIC_DIR
+
+
+class LocalConfigTest(TestCase):
+    def setUp(self):
+        self.runner = APP.test_cli_runner()
+
+    def test_local_config(self):
+        config_path = os.path.join(PUBLIC_DIR, "mappings", "test.yaml")
+        result = self.runner.invoke(
+            convert,
+            ["bbbb", "local-config-in", "local-config-out", "--config", config_path,],
+        )
+        self.assertIn("aaaa", result.stdout)
+        result = self.runner.invoke(
+            convert, ["b", "local-config-in", "eng-ipa", "--config", config_path,],
+        )
+        self.assertIn("ɑ", result.stdout)
+
+
+if __name__ == "__main__":
+    main()