Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config file documenting comments #155

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

rhansen
Copy link
Contributor

@rhansen rhansen commented Aug 23, 2023

  • Fix misleading unprivileged-user and chroot-dir documentation (leaving these values unset does not disable their respective features).
  • Document which files are read/created before chrooting and which are after.

Copy link
Owner

@roehling roehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes in general, but see the two comments I made.

data/postsrsd.conf.in Outdated Show resolved Hide resolved
data/postsrsd.conf.in Outdated Show resolved Hide resolved
  * Fix misleading `unprivileged-user` and `chroot-dir` documentation (leaving
    these values unset does not disable their respective features).
  * Document which files are read/created before chrooting and which are after.
@roehling roehling merged commit 5648050 into roehling:main Aug 25, 2023
10 checks passed
@rhansen rhansen deleted the docs branch August 25, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants