Move milter state creation from connect callback to envfrom #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If IPv6 support is not enabled in libmilter, the connect callback is not called when an IPv6 client connects. Work around the issue by moving state initialization from the connect callback to the envelope-from callback. Note that the state is now per-message, not per-connection, so it must be cleaned up in the end-of-message callback, in the abort callback, and in any other callback that finalizes message handling (e.g., tempfail).
|
Thanks. This is probably a better solution than my initial idea of patching IPv6 support in libmilter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If IPv6 support is not enabled in libmilter, the connect callback is not called when an IPv6 client connects. Work around the issue by moving state initialization from the connect callback to the envelope-from callback.
Note that the state is now per-message, not per-connection, so it must be cleaned up in the end-of-message callback, in the abort callback, and in any other callback that finalizes message handling (e.g., tempfail).
Fixes #156