Removed useless noop utils function

roeldev · Nov 18, 2015 · fbe13c7 · fbe13c7
1 parent 95dab43
commit fbe13c7
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 28 deletions.
diff --git a/gulpfile.js b/gulpfile.js
@@ -16,13 +16,17 @@ var Utils           = require('./lib/utils.js');
 
 var JS_SRC = ['gulpfile.js', 'lib/**/*.js', 'test/*.js'];
 
+function noop()
+{
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 
 Gulp.task('lint', function()
 {
     return Gulp.src(JS_SRC)
         .pipe( GulpJsHint() )
-        .pipe( GulpJsCs() ).on('error', Utils.noop)
+        .pipe( GulpJsCs() ).on('error', noop)
         .pipe( GulpJsCsStylish.combineWithHintResults() )
         .pipe( GulpJsHint.reporter('jshint-stylish') );
 });

diff --git a/lib/utils.js b/lib/utils.js
@@ -1,6 +1,5 @@
 /**
  * confirge | lib/utils.js
- * file version: 0.00.005
  */
 'use strict';
 
@@ -10,21 +9,14 @@ var _ = require('underscore');
 
 var Utils = module.exports =
 {
-    /**
-     * Empty function.
-     */
-    'noop': function noop()
-    {
-    },
-
     /**
      * Search for replacements and return a array with each replacement string.
      * Returns `false` when no replacements are found.
      *
      * @param {string} $str - The String to search in.
      * @return {array|boolean}
      */
-    'findReplacements': function findReplacements($str)
+    findReplacements: function findReplacements($str)
     {
         var $result = {};
         var $found  = false;
@@ -51,7 +43,7 @@ var Utils = module.exports =
      * @param {string} $level [''] - The current level
      * @return {object} Returns the result object so it can be passed down.
      */
-    'prepareVar': function prepareVar($result, $vars, $search, $level)
+    prepareVar: function prepareVar($result, $vars, $search, $level)
     {
         if (!_.isString($level))
         {
@@ -93,8 +85,7 @@ var Utils = module.exports =
             }
         }
 
-        $result[$level + $search] =
-        {
+        $result[$level + $search] = {
             'regexp':  new RegExp('%' + $level + $search + '%', 'g'),
             'replace': $replace
         };
@@ -108,7 +99,7 @@ var Utils = module.exports =
      * @param {string} $level [''] - The current level
      * @return {object} Returns the result object so it can be passed down.
      */
-    'prepareVars': function prepareVars($result, $vars, $level)
+    prepareVars: function prepareVars($result, $vars, $level)
     {
         if (!_.isString($level))
         {
@@ -146,7 +137,7 @@ var Utils = module.exports =
      * @param {object|function} $vars - Object with vars, { varName: value }.
      * @return {object|boolean}
      */
-    'prepareHandleVars': function prepareHandleVars($vars)
+    prepareHandleVars: function prepareHandleVars($vars)
     {
         if (_.isFunction($vars))
         {
@@ -171,7 +162,7 @@ var Utils = module.exports =
      * @param {object} $vars - The prepared vars to use for the replacements.
      * @return {string}
      */
-    'replaceVars': function replaceVars($str, $vars)
+    replaceVars: function replaceVars($str, $vars)
     {
         var $replacements = Utils.findReplacements($str);
         var $replacement;
@@ -207,7 +198,7 @@ var Utils = module.exports =
      * @param {object} $vars - Object with prepared vars.
      * @return {mixed}
      */
-    'replaceHandleItem': function replaceHandleItem($value, $vars)
+    replaceHandleItem: function replaceHandleItem($value, $vars)
     {
         if (_.isString($value))
         {
@@ -233,7 +224,7 @@ var Utils = module.exports =
      * @param {object} $vars - Object with prepared vars.
      * @return {array}
      */
-    'replaceHandleArray': function replaceHandleArray($array, $vars)
+    replaceHandleArray: function replaceHandleArray($array, $vars)
     {
         for (var $i = 0, $iL = $array.length; $i < $iL; $i++)
         {
@@ -251,7 +242,7 @@ var Utils = module.exports =
      * @param {object} $vars - Object with prepared vars.
      * @return {object}
      */
-    'replaceHandleObject': function replaceHandleObject($obj, $vars)
+    replaceHandleObject: function replaceHandleObject($obj, $vars)
     {
         for (var $key in $obj)
         {

diff --git a/test/main.js b/test/main.js
@@ -35,6 +35,10 @@ function getFixtureFile($file, $relative)
     return $file;
 }
 
+function noop()
+{
+}
+
 //------------------------------------------------------------------------------
 
 describe('Confirge()', function confirgeTests()
@@ -278,14 +282,6 @@ describe('Confirge.extend()', function confirgeExtendTests()
 
 //------------------------------------------------------------------------------
 
-describe('Utils.noop()', function utilsNoopTests()
-{
-    it('is only here to get 100% code coverage :P', function()
-    {
-        Assert.equal(Utils.noop(), null);
-    });
-});
-
 describe('Utils.findReplacements()', function utilsFindReplacementsTests()
 {
     it('found replacement [1]', function()
@@ -606,7 +602,7 @@ describe('Utils.replaceHandleItem()', function utilsReplaceHandleItemTests()
 
     it('should return the exact input value [2]', function()
     {
-        var $input = Utils.noop;
+        var $input = noop;
 
         Assert.strictEqual(Utils.replaceHandleItem($input, {}), $input);
     });