Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Logging #46

Closed
singjc opened this issue Nov 19, 2023 · 4 comments
Closed

[REFACTOR] Logging #46

singjc opened this issue Nov 19, 2023 · 4 comments
Labels
refactor Refactoring code

Comments

@singjc
Copy link
Collaborator

singjc commented Nov 19, 2023

Need to refactor and improve logging
@singjc singjc added the refactor Refactoring code label Nov 19, 2023
@jcharkow
Copy link
Collaborator

is this complete?

@singjc
Copy link
Collaborator Author

singjc commented Jan 25, 2024

is this complete?

For the most part, I think so. What do you think about the current logging? Are there any additional places that require it?

@jcharkow
Copy link
Collaborator

I think there are some places that take verbose arguments that do not use however I think overall we are at a good spot?

@singjc
Copy link
Collaborator Author

singjc commented Jan 25, 2024

I think there are some places that take verbose arguments that do not use however I think overall we are at a good spot?

Yip I think so, can close this then

@singjc singjc closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@singjc @jcharkow