Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft drop fix was never looked at again after it was removed #37

Closed
GoogleCodeExporter opened this issue May 6, 2015 · 1 comment
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Soft drop in a mode like Grade Mania
2. Notice that soft drop is additive (i.e. current gravity + 1G as opposed to 
just 1G)

What is the expected output? What do you see instead?
In order to properly emulate all possible rules/games, there needs to be three 
kinds of soft drop as opposed to just two: normal, additive, and 
multiplicative. "Normal" should always set the soft drop speed to the given 
speed, without regard for the current gravity speeds, and it should be 
ineffective (besides locking, if that is enabled) when the gravity speed 
exceeds soft drop. "Additive" acts as normal soft drop does now, by adding the 
soft drop speed to the current gravity settings. "Multiplicative" already is a 
setting, where the "soft drop speed" is actually a multiplier of the current 
gravity speed.


Original issue reported on code.google.com by Zirc...@gmail.com on 20 Nov 2010 at 8:42

@GoogleCodeExporter
Copy link
Author

Fixed in r545

Original comment by Zirc...@gmail.com on 30 Nov 2010 at 5:31

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant