Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong URI for x_pmt if it's the only parameter #52

Closed
mjanser opened this issue Oct 7, 2018 · 1 comment
Closed

Wrong URI for x_pmt if it's the only parameter #52

mjanser opened this issue Oct 7, 2018 · 1 comment

Comments

@mjanser
Copy link
Contributor

mjanser commented Oct 7, 2018

When using the plugin with a Octopus NET it sometimes tries to do requests like rtsp://[ip]/stream=1&x_pmt=2000 for encrypted channels. This request looks wrong because there should be a ? instead of &. The Octopus NET answers with a status code 400.

Is there a check missing here?

uri = cString::sprintf("%s&x_pmt=%d", *uri, pid);

The check is done some lines above:

uri = cString::sprintf("%s%sdelpids=%s", *uri, addPidsM.Size() ? "&" : "?", *delPidsM.ListPids());

@rofafor
Copy link
Owner

rofafor commented Oct 7, 2018

Yes, you're correct - I've never witnessed this situation as there have always been some pids defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants