Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The playlist type in libdmpcommon:message.hpp should become It's own class #2

Closed
Roflincopter opened this issue Jan 21, 2014 · 1 comment
Closed

The playlist type in libdmpcommon:message.hpp should become It's own class #2

Roflincopter opened this issue Jan 21, 2014 · 1 comment
Labels
enhancement

Comments

@Roflincopter
Copy link
Owner

There are 2 places where this type is magically introduced in the code. This should be fixed by creating a class. That contains the same type but more preferably a struct and a vector of structs to also remove the magic std::get(tuple) code that is used in the dmp_radio.{hpp,cpp}.
@Roflincopter
Copy link
Owner Author

Refactored in bc91d69c32675411efd8ba52e7aef4eca2a32f5a

The Playlist type is now defined in libdmp-common playlist.hpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Roflincopter