Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exception if plugin load fails using the load command #265

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

wiesendaniel
Copy link
Contributor

I've realized this might be missing.
Caught me as i was mostly hot-reloading my plugins during development.

@B3none
Copy link
Collaborator

B3none commented Jan 19, 2024

Going to run the build on this, and if it passes (which I suspect it will) I'll merge it.

@B3none
Copy link
Collaborator

B3none commented Jan 19, 2024

Going to run the build on this, and if it passes (which I suspect it will) I'll merge it.

I was going to do this but I didn't realise every push to main makes a release. I'll have to wait for @roflmuffin to advise.

@wiesendaniel
Copy link
Contributor Author

I ran into a lot of situation like this in the past. Maybe you want to create a next or release branch. Merge everything on this and do a single merge to main. Let me know if you need me to change the target branch or something.

@B3none B3none changed the base branch from main to v149-development January 21, 2024 01:33
@B3none B3none merged commit 4f1444e into roflmuffin:v149-development Jan 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants