Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Menu improvements #284

Merged
merged 9 commits into from
Jan 23, 2024
Merged

HTML Menu improvements #284

merged 9 commits into from
Jan 23, 2024

Conversation

Dliix66
Copy link
Contributor

@Dliix66 Dliix66 commented Jan 22, 2024 •
edited

Here are the changes:

  • Removed 1 max option per page on HTML display to avoid truncated option (only the "!9 -> Close" could be truncated)
  • Moved "Prev Page" from "!1" to "!7" to match old Radio Menus' behavior for all menus
  • Added grey color for disabled options in HTML
  • Made "Prev Page" option yellow just like next page

And here is the result:

  1. Max options in a menu
    image

  2. Prev Option
    image

  3. Disabled options
    image

B3none
B3none approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@B3none B3none left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look legit, thanks! 🙏

@roflmuffin roflmuffin merged commit e97f804 into roflmuffin:main Jan 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roflmuffin roflmuffin roflmuffin approved these changes

@B3none B3none B3none approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dliix66 @roflmuffin @B3none