Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy CCSPlayerController #287

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Tidy CCSPlayerController #287

merged 4 commits into from
Jan 26, 2024

Conversation

B3none
Copy link
Collaborator

@B3none B3none commented Jan 23, 2024

  • Removed redundant calls to "this."

@B3none B3none marked this pull request as ready for review January 23, 2024 16:03
@KillStr3aK
Copy link
Contributor

the project indeed doesn't follow the 'this' usage in the codestyle, however its only considered as redundant in given contexts

roflmuffin
roflmuffin approved these changes Jan 26, 2024
View reviewed changes
Copy link
Owner

@roflmuffin roflmuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will probably add an editor config for this eventually

@roflmuffin roflmuffin enabled auto-merge (squash) January 26, 2024 06:01
@roflmuffin roflmuffin merged commit 9071d51 into main Jan 26, 2024
4 checks passed
@roflmuffin roflmuffin deleted the chore/tidy-ccs-player-controller branch January 26, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roflmuffin roflmuffin roflmuffin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B3none @KillStr3aK @roflmuffin