Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Rehydration for nullable sheets #609

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Conversation

robinweser
Copy link
Owner

@robinweser robinweser commented Sep 21, 2018

Description

Fixes a bug for Safari 12 where rehydrated sheets yield null when using IE-specific media queries.

Versioning

Major

Minor

Patch

  • fela-dom

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

@robinweser robinweser merged commit 9b054b8 into master Sep 25, 2018
@robinweser robinweser deleted the safari-rehydration branch September 25, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant