Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Random MVP" option in menu. #25

Merged
merged 1 commit into from Sep 14, 2021

Conversation

kratos1812
Copy link
Contributor

Now players can select to have a random MVP Anthem every round via the menu.
As requested by https://forums.alliedmods.net/showpost.php?p=2755377&postcount=138

Now players can select to have a random MVP Anthem every round via the menu.
@No-Death
Copy link

Hello @kratos1812!
I tried this, seems like the volume is broken. Volume 0 works but everything else seems to be 100. Can you take a look? :)

@kratos1812
Copy link
Contributor Author

Hello @kratos1812!
I tried this, seems like the volume is broken. Volume 0 works but everything else seems to be 100. Can you take a look? :)

Hi, @No-Death
The official branch works good? I suspect this might not be related to my fork. I have to look more into it, I didn't have the time today.

@No-Death
Copy link

Hello @kratos1812!
I tried this, seems like the volume is broken. Volume 0 works but everything else seems to be 100. Can you take a look? :)

Hi, @No-Death
The official branch works good? I suspect this might not be related to my fork. I have to look more into it, I didn't have the time today.

I may have been wrong, I was in a hurry when I checked and my players complained about the volume. Seems like it may have been the sound that was used that just was loud. I will try again, sorry.

@rogeraabbccdd
Copy link
Owner

LGTM, thanks.

@rogeraabbccdd rogeraabbccdd merged commit c282ba1 into rogeraabbccdd:master Sep 14, 2021
@kratos1812 kratos1812 mentioned this pull request Oct 5, 2021
@crashzk
Copy link
Contributor

crashzk commented Feb 3, 2022

@kratos1812 just feedback on this update.

Random MVP option allows players even without privileges or access to MVP to choose this option. Even if there is no sound available for these unprivileged players, the plugin still shows on the screen if it is MVP if it chooses the random option.

#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants