Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup API does not accept Connection subclasses #199

Closed
kovidgoyal opened this issue Dec 13, 2015 · 1 comment
Closed

Backup API does not accept Connection subclasses #199

kovidgoyal opened this issue Dec 13, 2015 · 1 comment

Comments

@kovidgoyal
Copy link

This

apsw/src/connection.c

Line 594 in 5a20080

if(Py_TYPE(source)!=&ConnectionType)

should be changed to check for subclasses not only the exact type (use PyObject_IsInstance)
rogerbinns added a commit that referenced this issue Jan 26, 2016
@rogerbinns
Allow Connection subclasses for backups
1be8f22 
Fixes issue #199
@rogerbinns
Copy link
Owner

A grep of the code shows no similar code, so there shouldn't be any more of this family of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rogerbinns @kovidgoyal