Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break shell out of extension #356

Closed
rogerbinns opened this issue Aug 16, 2022 · 1 comment
Closed

Break shell out of extension #356

rogerbinns opened this issue Aug 16, 2022 · 1 comment
Assignees

Comments

@rogerbinns
Copy link
Owner

rogerbinns commented Aug 16, 2022

Currently the shell (python source) is included directly in the C extension via PyRun_StringFlags. This was desirable because it kept the binary as one file making deployment easier. However we are now a package and deployed via pypi so that doesn't matter. But there are also problems:

  • 2k lines of python code are evaluated on loading the module (even if the shell is never used)
  • any tracebacks say the file is <string>
  • harder to do coverage testing
  • type annotations aren't extracted automatically by mypy (it never loads the binary module)
@rogerbinns rogerbinns self-assigned this Aug 16, 2022
rogerbinns added a commit that referenced this issue Aug 23, 2022
rogerbinns added a commit that referenced this issue Aug 23, 2022
@rogerbinns
Copy link
Owner Author

This is now complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant