Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Track of Build Statuses #160

Merged
merged 2 commits into from Dec 3, 2021
Merged

Conversation

johnf
Copy link
Contributor

@johnf johnf commented Nov 27, 2021

Keeps track of the last X builds and sends a message as they appear and with their status
Resolves #13

@johnf johnf force-pushed the watch_build branch 2 times, most recently from 196f732 to f5171fa Compare November 27, 2021 22:58
src/fetch_app_status.rb Outdated Show resolved Hide resolved
src/poll-itc.js Outdated Show resolved Hide resolved
src/poll-itc.js Show resolved Hide resolved
Copy link
Owner

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks A LOT for this PR!! Your code LGTM, I just made some minor style adjustments, hope you don't mind.
Looking forward to using this feature 🌟 Nicely done!

@rogerluan rogerluan changed the title Keep track of when builds are ready. CLoses #13 Keep Track of When Builds are Ready Dec 3, 2021
@rogerluan rogerluan changed the title Keep Track of When Builds are Ready Keep Track of Build Statuses Dec 3, 2021
@rogerluan rogerluan merged commit 5fc83ea into rogerluan:master Dec 3, 2021
@johnf
Copy link
Contributor Author

johnf commented Dec 4, 2021

All good, thanks for merging!
Let me know when you do the next release if the docker workflow has any issues

@rogerluan
Copy link
Owner

rogerluan commented Dec 4, 2021

I just published a release https://github.com/rogerluan/app-store-connect-notifier/releases/tag/v2.2.0 💪 I'll let you know if there're any issues 😁 thanks for all your contributions!

@johnf
Copy link
Contributor Author

johnf commented Dec 4, 2021

You'll need to add two secrets , your docker hub username and password.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify When Builds Finish Processing
2 participants