Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to integrate Arkana's local Swift Package #25

Merged
merged 2 commits into from Jan 11, 2023
Merged

Document how to integrate Arkana's local Swift Package #25

merged 2 commits into from Jan 11, 2023

Conversation

alobaili
Copy link
Contributor

@alobaili alobaili commented Jan 6, 2023 •
edited

Closes #24

@alobaili alobaili mentioned this pull request Jan 6, 2023
Closed
rogerluan
rogerluan approved these changes Jan 9, 2023
View reviewed changes
Copy link
Owner

@rogerluan rogerluan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @alobaili ! I made some tweaks to formatting and wording, would you mind reviewing my changes? If you agree with them, then I can merge this PR 🚀

README.md Show resolved Hide resolved
alobaili
alobaili commented Jan 9, 2023
View reviewed changes
Copy link
Contributor Author

@alobaili alobaili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerluan Wonderful additions. I think it is clearer now. Thank you!

@rogerluan rogerluan changed the title #24 Add Xcode instructions to README.md Document how to integrate Arkana's local Swift Package Jan 11, 2023
@rogerluan rogerluan merged commit 9aabc65 into rogerluan:main Jan 11, 2023
@alobaili alobaili deleted the patch-1 branch March 1, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerluan rogerluan rogerluan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I ran arkana… what's the next step?
2 participants
@alobaili @rogerluan