Add ability to disable cross import of modules #35
Conversation
There was a problem hiding this comment.
Hi @jdanthinne 👋
Thanks for this proposal!
I left a few comments for you. Also, could you write unit tests that show that this config flag is working as expected? 🙏
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
|
For the unit test, as it is a preprocessor thing, it is hard to write that in the Swift tests. I guess it should be a Ruby unit test, but I must admit I don't know how it's done (I'm mainly an iOS dev). |
|
Please don't make a release with this change too soon. I think I've come across a strange case where this doesn't work as planed. |
|
😬 got it! |
|
@jdanthinne any update? Otherwise I'll revert this PR 🙏 please let me know. |
|
Sorry for the delay. It seems that in some configuration, my conditional compilation doesn't work as expected. I'll try to get back to you asap. |
|
Nevermind, it seems to work fine, finally. I guess Xcode was lost when I was switching back and forth when I was changing the code between Cocopoads and SPM usage. I re-tried everything today, and it's ok. |
|
Sounds good. Thank you @jdanthinne 👍 |
This PR adds to ability to remove the
import ArkanaKeysInterfacesstatement in ArkanaKeys module when used with Cocoapods.As I'm building an SDK using Arkana, importing via Pods, so I'm importing the Sources folder directly and this import statement was causing a compilation error, because all Sources are in the same module.