Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to generate secrets only for select environments #48

Merged
merged 9 commits into from Nov 16, 2023

Conversation

rogerluan
Copy link
Owner

Description

Resolves #31

Testing

To test this branch, modify your Gemfile as:

gem 'arkana', git: 'https://github.com/rogerluan/arkana.git', branch: 'roger/select-environments'

And run bundle install to apply the changes.

Then follow the documentation in the README (you can read the diff in this PR) to generate secrets only for select environments.

@rogerluan rogerluan self-assigned this Oct 21, 2023
@nishchal-v
Copy link

@rogerluan We have implemented the environment selection using the flag --include-environments flag, if we can make it shorter for something line --environments, or we can provide a shortcut flag like '-ev'.

Tested the PR for selection of environments and works like a charm ✨

@rogerluan
Copy link
Owner Author

Thanks for testing it out @nishchal-v ! 🤗

I've added a new shorthand flag for the --include-environents flag. Simply pass -i 😃

I decided to use --include-environments instead of e.g. --environments just so we can possibly implement --exclude-environments in the future if there's such need, without making it too confusing or needing breaking changes :)

@nishchal-v
Copy link

Okay, i understand that, thanks for providing the shorthand flag.

Tested the PR for the latest flag change and work fine, I think we are good to go for this PR from the functional point of view.

@rogerluan
Copy link
Owner Author

I'm merging this in :) Let me know if anyone encounter any issues!

@rogerluan rogerluan merged commit ee3e79f into main Nov 16, 2023
10 checks passed
@rogerluan rogerluan deleted the roger/select-environments branch November 16, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a feature to only build for a selected environment
2 participants