Handle corner case of values that look like numbers but should be treated as strings #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcacenabes
approved these changes
Dec 4, 2023
|
Merging this as I didn't hear back from the issue author for a few weeks 🙇 we can always go back and adjust this as needed :) Thanks for the feedback @dcacenabes 🙌 |
|
No no no, don't thank me. Thank you for the tool and for providing a fix!! I will closely watch for the release to update our dependency. We were in 1.1.1 and I just noticed the issue when we tried to bump to the latest version :) Looking forward to the new version getting released! |
|
haha no problem! ❤️ Aaaand it's out! https://github.com/rogerluan/arkana/releases/tag/v1.6.0 😊 Lemme know if you end up facing any issues! 🙇 |
|
Just updated it, worked like a charm, could finally build the app :D Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50