Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] OSX, disable the default sound #2289

Merged
merged 1 commit into from
Sep 4, 2014

Conversation

jtg-gg
Copy link
Member

@jtg-gg jtg-gg commented Sep 3, 2014

as requested by many user #27 (comment)
I agree with them, the notification sound can be played using audio api

@jamesmortensen
Copy link

Thanks @jtg-gg. This will help me move away from terminal-notifier for good! :)

rogerwang added a commit that referenced this pull request Sep 4, 2014
[Notification] OSX, disable the default sound
@rogerwang rogerwang merged commit eb10d7a into nwjs:master Sep 4, 2014
@jtg-gg jtg-gg deleted the notification-disable-sound branch October 31, 2014 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants