Implement desktop notifications [$100 awarded]

[zcbenz]

webkitNotifications can be implemented by overriding ShowDesktopNotification and CancelDesktopNotification in content browser client, chrome has already implemented them in chrome/browser/notifications, code can be reused there.

The $100 bounty on this issue has been claimed at Bountysource.

[Mithgol]

Hyperlinks for the future docs on this feature:

• Web Notifications — currently W3C Working Draft dated 14 June 2012
• Desktop Notifications‎ API Specification on the Cromium's site — also subject to change, and generally its visual design looks worse than at W3C

[Mithgol]

And somebody should tell that user to watch this issue.

[AndryBray]

Hi! Any news about this feature? Hope yes =)

[ChaitanyaPramod]

Desktop Notifications are very critical for any App to give a completely native experience. And for a chat app (which I'm trying to port from a chrome-extension), notifications are essential.
I wonder if anyone has tried the implementation suggested by @zcbenz in the description? If it looks simple enough, I might try it.

[katanacrimson]

+1

[AndryBray]

+1

[Anonyfox]

+1

[luxueyan2008]

me too

[YurySolovyov]

im not sure, but chrome 28+ should have notifications http://blog.chromium.org/2013/05/rich-notifications-in-chrome.html

[katanacrimson]

prior versions of chrome had it buried too under chrome://flags

[Mithgol]

I wonder if it does really mean that they appear then in Chromium/Blink code and then in node-webkit.

[AndryBray]

Please, could we know the place / priority of this feature in the roadmap?
Thank you

[Mithgol]

@Dream707

im not sure, but chrome 28+ should have notifications http://blog.chromium.org/2013/05/rich-notifications-in-chrome.html

That's rich notifications for Chrome packaged apps and extensions. A different thing.

Here we are talking about HTML5 Notifications API.

The real issue here is that typeof Notification === 'function' already (in node-webkit 0.6.1) and that you can call new Notification('some test'), but nothing happens.

[YurySolovyov]

maybe just a flag somewhere in build config or something? or some permission issues(you have to ask a permission in order to display notification)

[rogerwang]

Hello, thanks for your patience.

The reason this feature is in Chromium but not in node-webkit is: The feature is implemented in the Chromium browser, which is built on Content Layer, on which is node-webkit built. (node-webkit is on the same level with the browser part of Chromium.) So code for this is not in node-webkit.

I planed to move it to node-webkit but recently it's under refactoring to a new component (message center) in upstream. The good news is that the new component is more Content Layer friendly so it would make the move easier. Now the plan is to provide this feature in node-webkit 0.7.x or 0.8.x if upstream makes it ready on all the 3 platforms.

[Mithgol]

Thank you for explaining the current state of things.

[miklschmidt]

That sounds great @rogerwang thanks for the update!

[katanacrimson]

Please keep us posted - I guess we'll have to individually work around this and come up with some sort of temporary solution on our own.

For linux, at least, we've got notify-send.

[miklschmidt]

My extremely dependency heavy take at a workaround is here: https://gist.github.com/miklschmidt/5896306 if it's useful to anyone.

[katanacrimson]

@miklschmidt That's quite helpful, thanks! I'll probably have to pick it over myself to make it a bit more agnostic, but that is a great start.

I take it vendor/tween is tween.js?

Also - what is lib/gui?

[miklschmidt]

tween.js is TWEEN.js https://github.com/sole/tween.js/

lib/gui is just a require.js wrapper for require('nw.gui') i like to avoid using two types of dependency declarations in the same file :)

[vlados]

How we can help so this can be integrated as soon as possible?

[mbrevda]

+1

[jtg-gg]

I agree with you @jamesmortensen, I've made a pull request #2289

[victorzimmer]

+1

[adam-lynch]

Closed? Sorry, maybe I'm wrong, but are you settling for those tray tooltips on Windows?

IMO, they're not a good enough. Doesn't look like a real notification, can't show more than one at once, Windows is moving towards a different style notification since Windows 8, etc.

[edjafarov]

Just published replacement for rich desktop notifications check live -http://screencast.com/t/bUxB6vNvW8BN

https://github.com/edjafarov/node-webkit-desktop-notification
html5 Notification like API, better animations.

[edjafarov]

html5 notification ubuntu

[J-Rojas]

Hello, I've tried node-webkit v0.10.5 on Windows 7 (64 bit), Service Pack 1. When trying to create a new Notification, node-webkit crashed. This occurred with both a local script bundled into the application and also in an IFrame. Notifications on MacOSX and Ubuntu both worked.

If someone has had success on Windows 7, can you share what version of the OS and version of node-webkit worked for you. Thanks.

[sergiopvilar]

@joshleaves @jamesmortensen @jtg-gg this works fine! Thanks!

[marbemac]

Like @J-Rojas, I'm also seeing a crash in Windows 7 64 bit. The notifications are working fine in OS X and Linux. Does anybody have notifications working in Windows 7 (I have not tried other windows version yet)?

[jtg-gg]

@marbemac I've just tested the latest build, it works on my win 7 64 bit, hmm do you have the call stack for the crash ?

[marbemac]

@jtg-gg I checked the %TEMP% folder for the crash dump as described here https://github.com/nwjs/nw.js/wiki/Crash-dump but don't see anything. Is there somewhere else I should be looking?

When it crashes Windows only gives me a "programName.exe has stopped working. a problem caused the program to stop working correctly. Windows will close the program and notify you if a solution is available."

I took the notification code out to make sure, and sure enough the app booted fine. Then, in the dev console, I created a new notification while the app was running and it crashed.

[marbemac]

@jtg-gg I was able get the .dmp file. See this paste bin:

http://pastebin.com/869PPRku

Looks like something to do with storage.get?

[3664:0223/190703:FATAL:image.cc(748)] Check failed: storage_.get().

The code I'm using for the notification is just

new Notification("Title", {body: "Body"});

Thanks in advance for any help you can provide!

[jtg-gg]

@marbemac looks like, there is problem of getting the application icon, the notification, will try to get the application icon, if no image is specified

[victorzimmer]

If it works on OSX and Linux, but not Windows with fetching an image from the file tree it sounds a lot like a path error :P

—
Victor Zimmer

On Tue, Feb 24, 2015 at 5:46 AM, jtg-gg notifications@github.com wrote:

@marbemac looks like, there is problem of getting the application icon, the notification, will try to get the application icon, if no image is specified

Reply to this email directly or view it on GitHub:
#27 (comment)

[marbemac]

Hmm, where should I set this application icon? Is it required? If it makes any difference, I'm currently using https://github.com/mllrsohn/node-webkit-builder to build the app.

[marbemac]

@victorzimmer @jtg-gg I set the winIco option in node-webkit-builder but no luck - still crashes. Any other ideas? Do Windows 7 (64) notifications work for you guys when you build with node-webkit-builder (just to rule that out)?

[jtg-gg]

@marbemac can you try, to specify some jpg/png icon (http:// or file://) when you execute the notification ?

[marbemac]

@jtg-gg I updated my notification code test to the below, and it works fine in OS X, but still crashes in Windows. Any other ideas? And it's working in Windows 7 for you? This is so weird. Incidentally I did try it on another windows 7 computer and it crashed on that one as well. I've also tried several of the packaging methods listed in the wiki.

var options = {
        icon: "http://www.fnordware.com/superpng/pngtest16rgba.png",
        body: "Here is the notification text"
};

var notification = new Notification("Notification Title", options);

[marbemac]

Ok so the example here worked:
https://github.com/nwjs/nw.js/tree/master/tests/manual_tests/notification

Investigating..

[marbemac]

Solved, my manifest file had the window.icon set to a blank string. So many places to set an icon, I didn't notice that option in the manifest file. Thanks for the help guys!