feat(actionbasedpolicy): allowing set and get conditionResolver

src/Policy.test.ts

@@ -23,4 +23,30 @@ describe('Policy Class', () => {
       expect(policy.getContext()).toBe(context);
     });
   });
+
+  describe('when getConditionResolver', () => {
+    it('returns conditionResolver attribute', () => {
+      const conditionResolver = {
+        greaterThan: (data: number, expected: number): boolean => {
+          return data > expected;
+        }
+      };
+      expect(new Policy({ conditionResolver }).getConditionResolver()).toBe(
+        conditionResolver
+      );
+    });
+  });
+
+  describe('when setConditionResolver', () => {
+    it('sets conditionResolver attribute', () => {
+      const conditionResolver = {
+        greaterThan: (data: number, expected: number): boolean => {
+          return data > expected;
+        }
+      };
+      const policy = new Policy({});
+      policy.setConditionResolver(conditionResolver);
+      expect(policy.getConditionResolver()).toBe(conditionResolver);
+    });
+  });
 });

src/Policy.ts

@@ -1,12 +1,12 @@
-import { PolicyInterface, Context } from './types';
+import { MatchConditionInterface, ConditionResolver, Context } from './types';
 
 class Policy {
   protected context: Context;
+  protected conditionResolver: ConditionResolver;
 
-  constructor({ context }: PolicyInterface) {
-    if (context) {
-      this.context = context;
-    }
+  constructor({ context, conditionResolver }: MatchConditionInterface) {
+    this.context = context;
+    this.conditionResolver = conditionResolver;
   }
 
   setContext(context: Context): void {
@@ -16,6 +16,14 @@ class Policy {
   getContext(): Context {
     return this.context;
   }
+
+  setConditionResolver(conditionResolver: ConditionResolver): void {
+    this.conditionResolver = conditionResolver;
+  }
+
+  getConditionResolver(): ConditionResolver {
+    return this.conditionResolver;
+  }
 }
 
 export { Policy };

src/Statement.test.ts

@@ -51,6 +51,7 @@ describe('Statement Class', () => {
   describe('when match conditions', () => {
     it('returns true', () => {
       const firstStatementConfig = {
+        sid: 'first',
         condition: {
           greaterThan: { 'user.age': 30 }
         }

src/types.ts

@@ -49,10 +49,6 @@ export interface StatementInterface {
   condition?: ConditionBlock;
 }
 
-export interface PolicyInterface {
-  context?: Context;
-}
-
 export interface DecomposeString {
   start: number;
   end: number;

src/utils/memoize.ts

@@ -35,15 +35,15 @@ import { MemoizeInterface } from '../types';
  * ```
  */
 export function memoize(func: Function, resolver?: Function): MemoizeInterface {
-  const memoized = function(this: Function, ...args: any): MemoizeInterface {
+  const memoized = function (this: Function, ...args: any): MemoizeInterface {
     const key = resolver ? resolver.apply(this, args) : args[0];
     const cache = memoized.cache;
 
     if (cache.has(key)) {
       return cache.get(key);
     }
     const result = func.apply(this, args);
-    memoized.cache = cache.set(key, result) || cache;
+    cache.set(key, result);
     return result;
   };
   memoized.cache = new Map();

src/utils/mersenneTwister.test.ts

@@ -1,24 +1,42 @@
 import { MersenneTwister } from './mersenneTwister';
 
 describe('MersenneTwister', () => {
-  it('should repeat random sequence on same seed', () => {
-    const mersenne = new MersenneTwister();
+  describe('when using an empty array as seed', () => {
+    it('sets 5489 as seed', () => {
+      const mersenne = new MersenneTwister([]);
 
-    const seed = 123;
+      expect(mersenne.randomInt32()).toEqual(3499211612);
+    });
+  });
+
+  describe('when using empty with length greater or equal than 624', () => {
+    it('returns a MersenneTwister instance', () => {
+      expect(new MersenneTwister(new Array(624))).toBeInstanceOf(
+        MersenneTwister
+      );
+    });
+  });
+
+  describe('when using initSeed', () => {
+    it('repeats random sequence on same seed', () => {
+      const mersenne = new MersenneTwister();
 
-    mersenne.initSeed(seed);
-    const first1 = mersenne.randomReal2();
-    const first2 = mersenne.randomReal2();
+      const seed = 123;
 
-    mersenne.initSeed(seed);
-    const second1 = mersenne.randomReal2();
-    const second2 = mersenne.randomReal2();
+      mersenne.initSeed(seed);
+      const first1 = mersenne.randomReal2();
+      const first2 = mersenne.randomReal2();
 
-    expect(first1).toEqual(second1);
-    expect(first2).toEqual(second2);
+      mersenne.initSeed(seed);
+      const second1 = mersenne.randomReal2();
+      const second2 = mersenne.randomReal2();
+
+      expect(first1).toEqual(second1);
+      expect(first2).toEqual(second2);
+    });
   });
 
-  it('should allow seeding via constructor', () => {
+  it('allows seeding via constructor', () => {
     const seed = 325;
     const mersenne1 = new MersenneTwister(seed);
     const mersenne2 = new MersenneTwister(seed);
@@ -36,7 +54,7 @@ describe('MersenneTwister', () => {
   Modify the mtTest.c file to try each function with the proper seed
   */
   describe('when comparing with results from C language', () => {
-    it('should generate 100 Int32 values as C', () => {
+    it('generates 100 Int32 values as C', () => {
       const seeds = [0x123, 0x234, 0x345, 0x456];
       const mersenne = new MersenneTwister(seeds);
 
@@ -148,7 +166,7 @@ describe('MersenneTwister', () => {
       }
     });
 
-    it('should generate 100 Int31 values as C', () => {
+    it('generates 100 Int31 values as C', () => {
       const seeds = [0x123, 0x234, 0x345, 0x456];
       const mersenne = new MersenneTwister(seeds);
 
@@ -260,7 +278,7 @@ describe('MersenneTwister', () => {
       }
     });
 
-    it('should generate 100 Real1 values as C', () => {
+    it('generates 100 Real1 values as C', () => {
       const seeds = [0x123, 0x234, 0x345, 0x456];
       const mersenne = new MersenneTwister(seeds);
 
@@ -372,7 +390,7 @@ describe('MersenneTwister', () => {
       }
     });
 
-    it('should generate 100 Real2 values as C', () => {
+    it('generates 100 Real2 values as C', () => {
       const seeds = [0x123, 0x234, 0x345, 0x456];
       const mersenne = new MersenneTwister(seeds);
 
@@ -484,7 +502,7 @@ describe('MersenneTwister', () => {
       }
     });
 
-    it('should generate 100 Real3 values as C', () => {
+    it('generates 100 Real3 values as C', () => {
       const seeds = [0x123, 0x234, 0x345, 0x456];
       const mersenne = new MersenneTwister(seeds);
 
@@ -596,7 +614,7 @@ describe('MersenneTwister', () => {
       }
     });
 
-    it('should generate 100 Real3 values as C', () => {
+    it('generates 100 Real3 values as C', () => {
       const seeds = [0x123, 0x234, 0x345, 0x456];
       const mersenne = new MersenneTwister(seeds);
 

src/utils/mersenneTwister.ts

@@ -69,7 +69,7 @@ export class MersenneTwister {
     this.mti = this.N + 1; /* mti==N+1 means mt[N] is not initialized */
 
     if (Array.isArray(seed)) {
-      this.initByArray(seed, seed.length);
+      if (seed.length > 0) this.initByArray(seed, seed.length);
     } else {
       if (seed === undefined) {
         this.initSeed(new Date().getTime());