Setting "principalType" in evaluation as something not found in statement throws an error

[yaser-ali-s]

I tried setting the following:

const test = new ResourceBasedPolicy(
  {
    statements: [
      {
        action   : "*",
        resource : "*",
        principal: {
          a: "*",
          b: "*",
          c: "*",
        }
      }
    ]
  }
)

test.evaluate({
  action: "read",
  resource: "secrets:ultraSecret",
  principal: "secret",
  principalType: "d",
//context: {} 
})

I get a different error depending on whether I add a context or not:

• Without context: Cannot read property 'trim' of undefined
• With context : Cannot read property 'replace' of undefined

---

In both cases the error occurs because of the following line:

// iam-policies/src/ResourceBasedStatement.ts#L186
return new Matcher(applyContext(principalValues, context)).match(principal);

One is caused by new Matcher and the other by applyContext, because this.principal[principalType] is undefined.
I'd like to suggest the following amendment:

  private matchPrincipals(
    principal: string,
    principalType?: string,
    context?: T
  ): boolean {
    if (this.principal) {
      if (this.principal instanceof Array) {
        return principalType
          ? false
          : this.principal.some((a) =>
              new Matcher(applyContext(a, context)).match(principal)
            );
      } else {
+      const principalValues = this.principal[principalType];
+       if (principalValues) {
-       if (principalType) {
-         const principalValues = this.principal[principalType];
          if (principalValues instanceof Array) {
            return principalValues.some((a) =>
              new Matcher(applyContext(a, context)).match(principal)
            );
          }
          return new Matcher(applyContext(principalValues, context)).match(
            principal
          );
        }
        return false;
      }
    }
    return true;
  }

[roggervalf]

hey, thank you @yaser-ali-s for reporting this bug, let me address it

[roggervalf]

🎉 This issue has been resolved in version 4.8.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀