Context set in policy does not register for IdentityBasedPolicy and ResourceBasedPolicy

[yaser-ali-s]

Really sorry to be annoying but I'm working heavily with your project and really appreciate all the effort you've put into it.

It seems the context set during instantiation of IdentityBasedPolicy and ResourceBasedPolicy is not respected, as seen:

// IdentityBasedPolicy.ts
  can(
    this: IdentityBasedPolicy<T>,
    { action, resource, context }: EvaluateIdentityBasedInterface<T>
  ): boolean {
    return this.allowStatements.some((s) =>
      s.matches({
        action,
        resource,
        context, // <-- Not using this.context
        conditionResolver: this.conditionResolver
      })
    );
  }

  cannot(
    this: IdentityBasedPolicy<T>,
    { action, resource, context }: EvaluateIdentityBasedInterface<T>
  ): boolean {
    return this.denyStatements.some((s) =>
      s.matches({
        action,
        resource,
        context, // <-- Not using this.context
        conditionResolver: this.conditionResolver
      })
    );
  }
}

// ResourceBasedPolicy.ts
  can(
    this: ResourceBasedPolicy<T>,
    {
      principal,
      action,
      resource,
      principalType,
      context
    }: EvaluateResourceBasedInterface<T>
  ): boolean {
    return this.allowStatements.some((s) =>
      s.matches({
        principal,
        action,
        resource,
        principalType,
        context, // <-- Not using this.context
        conditionResolver: this.conditionResolver
      })
    );
  }

  cannot(
    this: ResourceBasedPolicy<T>,
    {
      principal,
      action,
      resource,
      principalType,
      context
    }: EvaluateResourceBasedInterface<T>
  ): boolean {
    return this.denyStatements.some((s) =>
      s.matches({
        principal,
        action,
        resource,
        principalType,
        context, // <-- Not using this.context
        conditionResolver: this.conditionResolver
      })
    );
  }
}

It is, however, respected in the ActionBasedPolicy:

// ActionBasedPolicy.ts
  can(
    this: ActionBasedPolicy<T>,
    { action, context }: EvaluateActionBasedInterface<T>
  ): boolean {
    return this.allowStatements.some((s) =>
      s.matches({
        action,
        context: context || this.context,
        conditionResolver: this.conditionResolver
      })
    );
  }

  cannot(
    this: ActionBasedPolicy<T>,
    { action, context }: EvaluateActionBasedInterface<T>
  ): boolean {
    return this.denyStatements.some((s) =>
      s.matches({
        action,
        context: context || this.context,
        conditionResolver: this.conditionResolver
      })
    );
  }

[roggervalf]

Hi @yaser-ali-s, thanks for submitting this bug, let me take a look on this.

[roggervalf]

🎉 This issue has been resolved in version 4.8.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀