Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute, optimize, analyze #7

Closed
rogiersbart opened this issue Jun 21, 2019 · 2 comments
Closed

Execute, optimize, analyze #7

rogiersbart opened this issue Jun 21, 2019 · 2 comments
Assignees
@rogiersbart
Labels
api 🔨 change likely to affect existing code feature 💡 request for new functionality wip ⏳ work in progress

Comments

@rogiersbart
Copy link
Owner

rogiersbart commented Jun 21, 2019 •
edited
Loading

I'd like to modify the api for executing MODFLOW. Currently, we have rmf_run_modflow(), rmf_run_opt(), rmf_run_sen() and rmf_run_rsm() for executing the model, optimization, sensitivity analysis and response surface mapping respectively. I think replacing the first three with rmf_execute(), rmf_optimize() and rmf_analyze would make things more clear. Furthermore, I think the optimization functionality should be reduced to standard local optimization only (with bounds, so only L-BGFS-B probably). The rest should at one point go to a separate package (e.g. RMODFLOW.invert). This relates to the idea of compatibility with, and limiting RMODFLOW functionality to ModelMuse (and friends ModelMate, ModelViewer, GW_Chart, ListingAnalyst). This package could then also include something like the current rmf_run_rsm(), and much more exotic things probably in the long run.
@rogiersbart rogiersbart added feature 💡 request for new functionality api 🔨 change likely to affect existing code labels Jun 21, 2019
@rogiersbart
Copy link
Owner Author

rogiersbart commented Jun 21, 2019 •
edited
Loading

Note we should also look into replacing system() and shell() calls by processx or sys.

@rogiersbart rogiersbart mentioned this issue Jan 28, 2020
Open
@cneyens cneyens mentioned this issue Jan 30, 2020
Merged
@rogiersbart rogiersbart self-assigned this Jan 30, 2020
@rogiersbart rogiersbart added the wip ⏳ work in progress label Jan 30, 2020
@rogiersbart
Copy link
Owner Author

This functionality was added by #19 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogiersbart rogiersbart

Labels
api 🔨 change likely to affect existing code feature 💡 request for new functionality wip ⏳ work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rogiersbart