-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package object structure: Dimensions, and maybe other things #21
Comments
I think this was introduced in #8 and added for HOB in #14. My apologies for not explicitly stating the breaking changes. So let me first explain the choices. They only affect boundary condition objects + HOB by the way. The idea for #8 was to make it easier (less verbose) to create boundary condition objects. Instead of supplying every data set as a separate function argument to For Removing the |
Ok, makes sense. Definitely the data frame part (just wondering now what the status of data.frame vs tibble use is currently, but might look into that later (note I would prefer using the latter throughout the package, mainly because of the more user-friendly printing)). Need to look deeper into the kper thing as well once, but that's ok for now. I will remove the dimensions layer in a feature branch then asap, and check if |
Currently, everything except
If you want me to do that just let me know; since I introduced it in the first place. More than happy to help. |
If you have time for that, that would be great. Just put it in a data-frame-to-tibble feature branch or so. Should be straightforward to merge. |
Remove dimensions level. Fixes #21.
Oh, I see I misinterpreted your suggestion above. Well ... had to fix things asap to continue working on one of the projects. The tibble thing can be done later I suppose. It's more a UI thing than anything else I think, so maybe I'll try to do that when introducing rui throughout the package (unless you feel like taking action already of course). Will close this one now. |
I just noted the current development branch contains a change to many (if not all) of the package object structures: The parameters related to dimensions are now exposed as
object$dimensions$np
instead ofobject$np
for instance. That seems to be quite a breaking change, which I should have noticed before, and is actually breaking some of my RMODFLOW code.I am prepared to adapt, but we need to discuss this I believe. My philosophy was, any dataset/variable defined in the online guide, which can be easily exposed to the user as
object$name
should be exposed in such a way. In case of MODFLOW parameters, I believe it indeed becomes too difficult, but plain integers ashob$nh
,hob$mobs
,hob$maxm
should still be available like that if you ask me. This seems much more user friendly.Any thoughts?
The text was updated successfully, but these errors were encountered: