If the height is changed from the outside while the open/close process has never been executed, it will not synchronize. #100
Labels
Comments
|
This problem does not seem to occur in React v17 but from v18. The same problem does not occur in v18 unless StrictMode is used. |
roginfarrer
added a commit
that referenced
this issue
Nov 27, 2022
## BREAKING CHANGES - Adopts React 18's `useId`, making the library incompatible with React <18 - Switch to `tsup` from `microbundle` for bundling library. No longer exports a UMD version, just CJS and MJS ## Features & Bug fixes - Refactors core functionality to vanilla JS (with a React) adapter, which I think should fix #103 and fix #100 - Added `onExpandedChange` option - Tries to detect if `getToggleProps` is used. If the toggle element ref can be accessed, the `aria-labelledby` attribute will be added to the collapse element - Added `role="region"` to collapse - Updated toggle props to pass the appropriate attributes to the element, whether it's a button or not
|
🎉 This issue has been resolved in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
roginfarrer
pushed a commit
that referenced
this issue
Nov 27, 2022
BREAKING CHANGES - Adopts React 18's `useId`, making the library incompatible with React <18 - Switch to `tsup` from `microbundle` for bundling library. No longer exports a UMD version, just CJS and MJS Features & Bug fixes - Refactors core functionality to vanilla JS (with a React) adapter, which I think should fix #103 and fix #100 - Added `onExpandedChange` option - Tries to detect if `getToggleProps` is used. If the toggle element ref can be accessed, the `aria-labelledby` attribute will be added to the collapse element - Added `role="region"` to collapse - Updated toggle props to pass the appropriate attributes to the element, whether it's a button or not
|
🎉 This issue has been resolved in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Meant to release at v4@next, but couldn't figure out the magic words for semantic-release 🤷🏻. Can you try testing with |
|
@roginfarrer Thanks for getting back to me! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If it is initially open and a change occurs that changes the internal height, react-collapsed will not reflect the change.
After the second time, the height is correctly recognized as normal.
Reproducing URL:
https://stackblitz.com/edit/react-ts-23bci9?file=App.tsx
Pressing the "+1" button does not change the height of the item, so the item is not fully displayed.
If you press the "Toggle" button once, the height will always be updated, with all items displayed.
I'm assuming this behavior is probably a bug, not a specification. But I don't know much about it.
I am not sure if this is the scope of react-collapsed too.
defaultExpandedvalue has no effect.The text was updated successfully, but these errors were encountered: