Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Respond to height updates during animations #29

Closed
Titozzz opened this issue Sep 18, 2019 · 4 comments · Fixed by #30
Closed

[Request] Respond to height updates during animations #29

Titozzz opened this issue Sep 18, 2019 · 4 comments · Fixed by #30

Comments

@Titozzz
Copy link
Contributor

Titozzz commented Sep 18, 2019

As said in #28, animating and changing height at the same time is not working properly. Do you think this is fixable, or this is by design from that library and cannot change?

Do you need a reproduction?

Thank you so much for the lib and your time :)

@Titozzz
Copy link
Contributor Author

Titozzz commented Sep 18, 2019

We improvised something that's working. If the height is updated it will animate another time to the new height.

@roginfarrer
Copy link
Owner

Do you need a reproduction?

A reproduction would be great! A gif would also work well, since I know timing this can be hard.

@Titozzz
Copy link
Contributor Author

Titozzz commented Sep 23, 2019

There you go:
Edit hardcore-morse-23we0

Click, let it "load", close it, and reopen it

@roginfarrer
Copy link
Owner

Ah, makes sense! Taking a closer look at the PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants