Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port https://go-review.googlesource.com/c/go/+/191197 #108

Closed
smasher164 opened this issue Aug 27, 2020 · 1 comment · Fixed by #111
Closed

Port https://go-review.googlesource.com/c/go/+/191197 #108

smasher164 opened this issue Aug 27, 2020 · 1 comment · Fixed by #111

Comments

@smasher164
Copy link
Contributor

No description provided.

@myitcv
Copy link
Collaborator

myitcv commented Aug 27, 2020

Sounds good.

smasher164 added a commit to smasher164/go-internal that referenced this issue Sep 23, 2020
@smasher164
fmtsort: don't out-of-bounds panic if there's a race condition
7c95846 
Applied upstream CL 191197 to mapelem.go. Cannot fully port to 1.11,
since MapRange started to be supported in 1.12, but we can still avoid
an index out-of-bounds panic.

Fixes rogpeppe#108.
@smasher164 smasher164 mentioned this issue Sep 23, 2020
Merged
mvdan pushed a commit that referenced this issue Oct 11, 2020
@smasher164 @mvdan
fmtsort: don't out-of-bounds panic if there's a race condition
9f985d5 
Applied upstream CL 191197 to mapelem.go. Cannot fully port to 1.11,
since MapRange started to be supported in 1.12, but we can still avoid
an index out-of-bounds panic.

Fixes #108.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fmtsort: don't out-of-bounds panic if there's a race condition smasher164/go-internal
2 participants
@myitcv @smasher164