Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockedfile: update from Go master #186

Merged
merged 1 commit into from Nov 14, 2022
Merged

lockedfile: update from Go master #186

merged 1 commit into from Nov 14, 2022

Conversation

rogpeppe
Copy link
Owner

Code taken from upstream commit d7dbe0111ef2a6de80a20fef188db61d8fab5c96.

This adds a new function (Transform).

Copy link
Collaborator

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one suggestion: where the changes in this PR are not mechanical copies from upstream, we should document the differences.

@mvdan
Copy link
Collaborator

mvdan commented Nov 11, 2022

Similar nit: assuming you used a tool like gomvpkg, document how you ran it in the commit message :)

Code taken from upstream commit d7dbe0111ef2a6de80a20fef188db61d8fab5c96.

Manual updates:
- changed import paths
- added `// +build` lines
- changed `!unix` build tag in `internal/filelock/filelock_other.go`
- removed call to `testenv.MustHaveExec` in `internal/filelock/filelock_test.go`.
@rogpeppe
Copy link
Owner Author

Updated commit message accordingly.

@rogpeppe rogpeppe merged commit bdb7893 into master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants