Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testscript: expose (*TestScript).stdout via Stdout() #216

Merged
merged 1 commit into from Apr 27, 2023
Merged

testscript: expose (*TestScript).stdout via Stdout() #216

merged 1 commit into from Apr 27, 2023

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Apr 25, 2023

(see commit message)

@myitcv myitcv force-pushed the expose_testscript_stdout_stderr branch from 4ca5004 to c5cb324 Compare April 25, 2023 19:45
@myitcv myitcv requested review from mvdan and rogpeppe April 25, 2023 19:45
@myitcv
Copy link
Collaborator Author

myitcv commented Apr 25, 2023

Noting previous exchanges in #140

mvdan
mvdan approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we're OK with Stdout/Stderr not being safe for concurrent use.

testscript/testscript.go Outdated Show resolved Hide resolved
@myitcv myitcv force-pushed the expose_testscript_stdout_stderr branch 5 times, most recently from 6d2e77c to d3aa1fd Compare April 26, 2023 19:59
@myitcv
Copy link
Collaborator Author

myitcv commented Apr 26, 2023

@mvdan @rogpeppe - PTAL

@myitcv myitcv force-pushed the expose_testscript_stdout_stderr branch from d3aa1fd to ebf36fa Compare April 26, 2023 20:06
@myitcv myitcv mentioned this pull request Apr 26, 2023
Closed
@myitcv myitcv requested a review from mvdan April 26, 2023 20:15
mvdan
mvdan approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

testscript/testscript.go Outdated Show resolved Hide resolved
testscript/testscript.go Outdated Show resolved Hide resolved
@myitcv
testscript: expose (*TestScript).stdout via Stdout()
ca28326 
Similarly, expose (*TestScript).stderr via Stderr().

Closes #139
@myitcv myitcv force-pushed the expose_testscript_stdout_stderr branch from ebf36fa to ca28326 Compare April 27, 2023 07:16
@myitcv myitcv merged commit 22b9127 into master Apr 27, 2023
6 checks passed
@myitcv myitcv deleted the expose_testscript_stdout_stderr branch April 27, 2023 13:50
ldemailly pushed a commit to fortio/testscript that referenced this pull request May 7, 2023
@myitcv @ldemailly
testscript: expose (*TestScript).stdout via Stdout() (rogpeppe#216)
6e3acf8 
Similarly, expose (*TestScript).stderr via Stderr().

Closes rogpeppe#139
@mvdan mvdan mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

@rogpeppe rogpeppe Awaiting requested review from rogpeppe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myitcv @mvdan