Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: fail a test when a testscript Dir contains no scripts #85

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Dec 17, 2019

This can happen when either the Dir does not exist, or it is empty.

@myitcv myitcv force-pushed the testscript_fix_dir_no_exist_or_empty branch from c1c7ed9 to 6c0769c Compare December 17, 2019 21:27
Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this! LGTM modulo one suggestion.

testscript/testscript.go Outdated Show resolved Hide resolved
@myitcv myitcv force-pushed the testscript_fix_dir_no_exist_or_empty branch from 6c0769c to 64c7ff1 Compare December 18, 2019 14:07
This can happen when either the Dir does not exist, or it is empty.
@myitcv myitcv force-pushed the testscript_fix_dir_no_exist_or_empty branch from 64c7ff1 to 5254eb5 Compare December 18, 2019 16:21
@myitcv myitcv merged commit bf08ea5 into master Dec 18, 2019
@myitcv myitcv deleted the testscript_fix_dir_no_exist_or_empty branch December 18, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants