Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update golang.org/x/tools to v0.0.0-20200226224502-204d844ad48d #120

Merged
merged 4 commits into from
Mar 3, 2020
Merged

update golang.org/x/tools to v0.0.0-20200226224502-204d844ad48d #120

merged 4 commits into from
Mar 3, 2020

Conversation

hyangah
Copy link
Contributor

@hyangah hyangah commented Feb 27, 2020

Also update the vendor directory.

Fixes #118

@stamblerre stamblerre mentioned this pull request Feb 27, 2020
Closed
@hyangah
Copy link
Contributor Author

hyangah commented Feb 27, 2020

have no idea why travis is not picking up 1.14. @ianthehat @rogpeppe do you have any idea?

rogpeppe
rogpeppe approved these changes Mar 3, 2020
View reviewed changes
Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@rogpeppe rogpeppe merged commit 8318a68 into rogpeppe:master Mar 3, 2020
@hyangah
Copy link
Contributor Author

hyangah commented Mar 4, 2020

Thank you @rogpeppe !
Can you help tagging and releasing a new version, so modules mode users can pick up the updated code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogpeppe rogpeppe rogpeppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal error: nil Pkg importing "errors" from "mypkg"
2 participants
@hyangah @rogpeppe