Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported dynamic URLs in custom HTML pages #150

Closed
1 of 3 tasks
NickEckert opened this issue Apr 22, 2018 · 4 comments
Closed
1 of 3 tasks

Unsupported dynamic URLs in custom HTML pages #150

NickEckert opened this issue Apr 22, 2018 · 4 comments
Assignees
@RohanNagar
Labels
P1 High priority. Should be addressed by the next release. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. Status: In Progress Work on the issue is in progress. Type: Enhancement An enhancement of an existing feature.
Milestone
v2.0.0

Comments

@NickEckert
Copy link
Collaborator

This issue relates to a:

  • Bug
  • Suggestion
  • Feature Proposal

Description:

PR #135 added custom html pages but introduced a problem by preventing the inclusion of dynamic URL's in the html page. This makes it impossible for a user receiving a verification email to connect back to Thunder.

Additional Information:
@NickEckert NickEckert added Type: Enhancement An enhancement of an existing feature. P1 High priority. Should be addressed by the next release. Status: Available Work on this issue has not yet started and is available to be worked on. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. labels Apr 22, 2018
@NickEckert NickEckert added this to the v2.0.0 milestone Apr 22, 2018
@NickEckert NickEckert mentioned this issue Apr 22, 2018
Closed
3 tasks
@RohanNagar RohanNagar self-assigned this Apr 27, 2018
@RohanNagar RohanNagar added Status: In Progress Work on the issue is in progress. and removed Status: Available Work on this issue has not yet started and is available to be worked on. labels Apr 27, 2018
@RohanNagar
Copy link
Owner

Work is in progress on the url branch

@RohanNagar
Copy link
Owner

RohanNagar commented Apr 27, 2018 •
edited
Loading

TODO still:

  • Use UriInfo instead of configuration option
  • Add optional customization option for replacement string (will probably tackle this in a new PR. For now, custom pages must use CODEGEN-URL)
  • Add warning if String.contains("CODEGEN-URL") is false
  • Use baseUriBuilder ? https://www.mail-archive.com/users@cxf.apache.org/msg34526.html
  • Tests
  • Cleanup

@RohanNagar
Copy link
Owner

Instead of the baseUrl configuration option, we can do better by using @Context UriInfo uriInfo

https://stackoverflow.com/questions/7652321/getting-the-base-url-of-my-server-with-jax-rs

@RohanNagar RohanNagar mentioned this issue May 3, 2018
Merged
2 tasks
@RohanNagar
Copy link
Owner

Will open a new PR for customizing the replacement string.

@RohanNagar RohanNagar mentioned this issue May 3, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RohanNagar RohanNagar

Labels
P1 High priority. Should be addressed by the next release. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. Status: In Progress Work on the issue is in progress. Type: Enhancement An enhancement of an existing feature.
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@RohanNagar @NickEckert