Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dynamic URL injection in email messages #161

Merged
merged 9 commits into from
May 3, 2018
Merged

Enable dynamic URL injection in email messages #161

merged 9 commits into from
May 3, 2018

Conversation

RohanNagar
Copy link
Owner

This PR addresses:

  • Addresses most of Unsupported dynamic URLs in custom HTML pages #150.
  • No longer require methods with the @BeforeClass annotation to have a Javadoc comment.
  • Some general cleanup of email verification, including:
    • Rename the meter to send-email-requests
    • Test organization

I have verified that:

  • All related unit tests have been updated/created
  • Integration tests are passing

Additional Notes

Still missing in the option to configure a different value for the URL placeholder. Will address in a future PR.

@RohanNagar RohanNagar added Type: Enhancement An enhancement of an existing feature. P1 High priority. Should be addressed by the next release. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. labels May 3, 2018
@RohanNagar RohanNagar added this to the v2.0.0 milestone May 3, 2018
@RohanNagar RohanNagar requested a review from NickEckert May 3, 2018 01:43
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.124% when pulling 3e0710c on url into 9f4f5ff on master.

NickEckert
NickEckert approved these changes May 3, 2018
View reviewed changes
Copy link
Collaborator

@NickEckert NickEckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

@RohanNagar RohanNagar merged commit 61556d5 into master May 3, 2018
@RohanNagar RohanNagar deleted the url branch May 3, 2018 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickEckert NickEckert NickEckert approved these changes

Assignees
No one assigned
Labels
P1 High priority. Should be addressed by the next release. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. Type: Enhancement An enhancement of an existing feature.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@RohanNagar @coveralls @NickEckert