Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #9

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

[pre-commit.ci] pre-commit autoupdate #9

wants to merge 24 commits into from

Conversation

pre-commit-ci[bot]
Copy link

@pre-commit-ci pre-commit-ci bot commented Nov 22, 2021

rohanpm and others added 24 commits November 16, 2021 13:42
@rohanpm
Tolerate absent exodus-config
ab769b7
@rohanpm
Try adding an empty keygroup
9bbaec8
@rohanpm
Ensure KeyGroup has at least one key
7dd8764 
This is mandatory in order to create a group.
It will obviously have to be parametrized at some point.
@rohanpm
Fix references relating to keygroup
e18daf6
@rohanpm
WIP: test addition of a secret
ecd6146
@rohanpm
prototype a meta endpoint
d7f166c
@rohanpm
debugging around secret
0f019d1
@rohanpm
Don't catch
f6936ea
@rohanpm
Implement setting of cookies
958c930
@rohanpm
Bump python version
3ecdc79
@rohanpm
Fix type error on private key load
f8d6dd4
@rohanpm
Ensure policy is encoded before signing
8c56fba
@rohanpm
Fix header structure in response
12c393f
@rohanpm
Use cookie structure
cc7bec1 
We must use 'cookies' rather than Set-Cookie header.
@rohanpm
Disable caching from cookie endpoint
6111c4a
@rohanpm
Try viewer-request for setting cookies
435b3bb
@rohanpm
reftest: expand vars
5f8e5c7
@rohanpm
Revert "Try viewer-request for setting cookies"
6abfa40 
This won't work due to limited size.

This reverts commit 435b3bb.
@rohanpm
Adjust cookie forwarding behavior
338b3f6
@rohanpm
Fix WhitelistedNames syntax
ae5a41e
@rohanpm
Revert "Use cookie structure"
a01d2e9 
This change was not correct, set-cookie was not working for a different
reason.

This reverts commit cc7bec1.
@rohanpm
Add key, various tweaks
d6a5627
@rohanpm
fix: use full URL in resource
43b896e
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
a656545 
updates:
- https://github.com/ambv/black → https://github.com/psf/black
- [github.com/psf/black: 20.8b1 → 21.11b1](psf/black@20.8b1...21.11b1)
- https://github.com/pycqa/isort/: 5.6.4 → 5.10.1
@coveralls
Copy link

coveralls commented Nov 22, 2021 •
edited

Pull Request Test Coverage Report for Build 1491186094

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 23 of 69 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.561%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exodus_lambda/functions/signer.py 10 24 41.67%
exodus_lambda/functions/origin_request.py 13 45 28.89%
Totals Coverage Status
Change from base Build 1474861759: 0.0%
Covered Lines: 159
Relevant Lines: 205
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanpm rohanpm Awaiting requested review from rohanpm rohanpm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@coveralls @rohanpm