Refactor method chaining #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop Executors.wrap method, which is too dynamic for tools such as pylint to perform type inference. Replace it with a static API provided by mixins. Removal of the Executors.wrap method is is a backwards-incompatible API change. Fixes #86
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 26, 2018
89: Refactor method chaining r=rohanpm a=rohanpm Drop Executors.wrap method, which is too dynamic for tools such as pylint to perform type inference. Replace it with a static API provided by mixins. Removal of the Executors.wrap method is is a backwards-incompatible API change. Fixes #86 Co-authored-by: Rohan McGovern <rohan@mcgovern.id.au>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Executors.wrap method, which is too dynamic for tools such as
pylint to perform type inference. Replace it with a static API
provided by mixins.
Removal of the Executors.wrap method is is a backwards-incompatible
API change.
Fixes #86