Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata validation breaks with non-ascii characters #463

Closed
rhoerbe opened this issue Oct 3, 2017 · 2 comments
Closed

Metadata validation breaks with non-ascii characters #463

rhoerbe opened this issue Oct 3, 2017 · 2 comments

Comments

@rhoerbe
Copy link
Contributor

rhoerbe commented Oct 3, 2017

The XML infoset at http://mdfeed.test.portalverbund.gv.at/metadata.xml contains German Umlauts in XML elements. pysaml2.sigver breaks because the xml contents is not retrieved correctly (data/digest mismatch)
@rhoerbe
Copy link
Contributor Author

rhoerbe commented Oct 3, 2017

The relevant code (use requests.content instead of requests.text.encode(UTF-8) has already been fixed since 4.4.0. Please release the latest version to pypi.

@c00kiemon5ter
Copy link
Member

pysaml2 version 4.5.0 has been released. This can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c00kiemon5ter @rhoerbe