Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The configuration option 'valid_for' is not used #9

Closed
lorenzogil opened this issue Nov 6, 2012 · 0 comments
Closed

The configuration option 'valid_for' is not used #9

lorenzogil opened this issue Nov 6, 2012 · 0 comments
Labels

Comments

@lorenzogil
Copy link
Contributor

In the documentation (/doc/howto/config.rst) it says:

valid_for

How many hours this configuration is expected to be accurate.:

"valid_for": 24

This of course is only used by make_metadata.py. The server will not stop working when this amount of time has elapsed :-).

But in the make_metadata.py script this parameter is not read from the config file. It is read from a command line option.

I suggest we:

A) Remove that option from the documentation or
B) Use the option from the config file as a default value overridable by the command line switch. Or even better, remove the 'valid_for' parameter from the saml2.metadata.entity_descriptor function and read it from the config parameter that it is already receiving.

@rohe rohe closed this as completed May 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants