Fix ScrollYOffset reset when not using a selector (#163)

rohit-gohri · Apr 4, 2022 · 420c404 · 420c404 · vercel · Apr 4, 2022
1 parent e812293
commit 420c404
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/fuzzy-panthers-wink.md b/.changeset/fuzzy-panthers-wink.md
@@ -0,0 +1,5 @@
+---
+'docusaurus-theme-redoc': patch
+---
+
+fix scrollYOffset disable when not using selector
diff --git a/packages/docusaurus-theme-redoc/src/utils/useSpec.ts b/packages/docusaurus-theme-redoc/src/utils/useSpec.ts
@@ -24,8 +24,11 @@ export function useSpec({ spec, url }: SpecProps) {
     const { lightTheme, darkTheme, options: redocOptions } = themeOptions;
 
     const commonOptions: Partial<RedocRawOptions> = {
-      // Disable offset when server rendering
-      scrollYOffset: isBrowser ? redocOptions.scrollYOffset : 0,
+      // Disable offset when server rendering and set to selector
+      scrollYOffset:
+        !isBrowser && typeof redocOptions.scrollYOffset === 'string'
+          ? 0
+          : redocOptions.scrollYOffset,
     };
 
     // eslint-disable-next-line @typescript-eslint/no-explicit-any