Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useThemeContext and switch to the new useColorMode added in Canary. #117

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Conversation

homotechsual
Copy link
Contributor

@homotechsual homotechsual commented Jan 24, 2022

Closes #116

This fixes issue #116 by applying the fix for the breaking change in the latest canary build.
@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2022

⚠️ No Changeset found

Latest commit: f753e33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@homotechsual
Copy link
Contributor Author

Fixes #117

@rohit-gohri
Copy link
Owner

I will also update the dependencies and then merge this, currently it breaks the build. Thanks for the PR

@rohit-gohri rohit-gohri added the dependencies Pull requests that update a dependency file label Jan 24, 2022
@tanepiper
Copy link

Hi, I'm actually just looking into using this tool and I'm getting this error - when do you think it can be looked at to be merged? We need to serve a lot of OpenAPI docs and this looks like a good tool :)

@edumaciel10
Copy link

This it's so good

@slorber
Copy link

slorber commented Jan 28, 2022

sorry for the annoyance, maybe we should provide something to make it retrocompatible?

But we'll keep using the theme-common package in the future for such things and use the theme mostly for regular React components

@rohit-gohri
Copy link
Owner

Merging with failed build, fixing build in this follow up PR: #119
Release should be up soon

@rohit-gohri rohit-gohri merged commit f285992 into rohit-gohri:main Jan 28, 2022
@rohit-gohri
Copy link
Owner

Release is up: #122

@rohit-gohri
Copy link
Owner

sorry for the annoyance, maybe we should provide something to make it retrocompatible?

@slorber Might be nice, but I'm thinking if we can better declare this dependency b/w plugins<->docusaurus via peerDependencies? I don't currently add Docusaurus as a peer dependency, should I add it? I'm not sure how that would look like

@slorber
Copy link

slorber commented Feb 2, 2022

@rohit-gohri now you should add this @docusaurus/theme-common package as a dependency as you use it, so if we do changes on it, you may notice more easily if TS does not compile anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docusaurus Canary - Can't resolve useThemeContext
5 participants