Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't dispose store in SSR #210

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Don't dispose store in SSR #210

merged 2 commits into from
Jun 17, 2022

Conversation

rohit-gohri
Copy link
Owner

@rohit-gohri rohit-gohri commented Jun 17, 2022

Closes #209

Terminate isn't available in server and it's called on dispose here:
https://github.com/Redocly/redoc/blob/4fb5f914fa4fe05ee8b24cc15cb485f7b3538538/src/services/SearchStore.ts#L12-L14

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2022

🦋 Changeset detected

Latest commit: 07d2019

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
docusaurus-theme-redoc Patch
redocusaurus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rohit-gohri rohit-gohri added the bug Something isn't working label Jun 17, 2022
@vercel
Copy link

vercel bot commented Jun 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
redocusaurus ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 6:01PM (UTC)

@rohit-gohri rohit-gohri merged commit c55d03f into main Jun 17, 2022
@rohit-gohri rohit-gohri deleted the bugfix/worker-terminate-error branch June 17, 2022 18:13
@github-actions github-actions bot mentioned this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docusaurus failed to build when using redocusaurus > 1.1.2
1 participant