Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Add webpack to peer dependencies of redoc theme #323

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

zackerydev
Copy link
Contributor

@zackerydev zackerydev commented Jan 9, 2024

This fixes #322

Adding webpack to the peer dependencies correctly resolves this package to Webpack 5, which is requires for redoc 4.

Copy link

vercel bot commented Jan 9, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @rohit-gohri on Vercel.

@rohit-gohri first needs to authorize it.

Copy link

changeset-bot bot commented Jan 9, 2024

🦋 Changeset detected

Latest commit: 252b9b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
docusaurus-theme-redoc Patch
redocusaurus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -52,6 +52,7 @@
"node": ">=14"
},
"devDependencies": {
"typescript": "^5.2.2"
"typescript": "^5.2.2",
"webpack": "^5.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you will want this here - but it silences a yarn warning.

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
redocusaurus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 9:38am

Copy link
Owner

@rohit-gohri rohit-gohri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You can try adding the changeset by following the instructions, or I can also do it later

@zackerydev
Copy link
Contributor Author

@rohit-gohri Just pushed it up!

@rohit-gohri rohit-gohri merged commit 6770694 into rohit-gohri:main Jan 11, 2024
3 of 4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack missing in Peer Dependencies
2 participants