Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Switch to drawpart #4

Merged
merged 4 commits into from
Nov 16, 2015
Merged

WIP: Switch to drawpart #4

merged 4 commits into from
Nov 16, 2015

Conversation

rohitvarkey
Copy link
Owner

No description provided.

@shashi
Copy link
Collaborator

shashi commented Oct 20, 2015

It's probably time to start looking into adapting Compose3D into Compose. This branch uses Measures.jl and is about to be merged: GiovineItalia/Compose.jl#131

A first step would be to try to use Compose.drawpart, and the Compose ContainerNode types in Compose3D

@rohitvarkey
Copy link
Owner Author

@shashi The first step is what this PR is trying to achieve. But for 3D, it will need some extra steps like the camera and the lights which are the only modifications in drawpart I've made along with the removal of features Compose3D does not currently support like transforms and container promises.

Also lets get Compose3D working on its own nicely first before getting it integrated with Compose. :)

@rohitvarkey
Copy link
Owner Author

Also the reason why this is a WIP is that it's breaking the rotation and panning ability with the ThreeJS backend for some reason. Works fine on master. Been trying to track it down since morning unsuccessfully.

@rohitvarkey
Copy link
Owner Author

Okay. I ran into the bug again today while messing around with ThreeJS. So it's not a Compose3D issue, rather something to do threejs and trackballcontrols with the camera being set to (0.0, y, 0.0). All other coordinates seem to work. I'm going to change the default camera and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants