Log unpermitted parameters #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def logger | ||
| Lograge.logger.presence || super | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def extract_request(payload) | ||
| def extract_request(event, payload) |
There was a problem hiding this comment.
FWIW the data building & the associated private methods could be extracted into an inline class to separate it from the LogSubscriber messages, but I wasn't sure how far it would be worth taking this refactor.
|
Thanks! Would you mind updating the change log? This is looking good to merge. ❤️ |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152.
This will only log if
config.action_controller.action_on_unpermitted_parameters = :log.This PR also refactors LogSubscriber to make rubocop happy.