No upper bound dependencies on AS/AP/Railties #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These upper bound dependencies make it so that every time I go to upgrade a Rails version, I need to point to a fork of Lograge until you guys release a new version. I don't see the major benefit of having an upper bound dependency. It just creates noise/busy work for you guys. If people have issues with later versions of Rails they will report them.
In my project of ~100 gems, Lograge and 2-3 others always come up when I go to do Rails upgrades for this reason. Last time around I helped pitch in (#208), but I think it doesn't make sense to keep doing it this way.
What do you guys think?