Strip query string from the log for Location headers #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Location URL may contain sensitive information, so just like the path we should remove the query string. Closes roidrage#229
stanhu
force-pushed
the
sh-strip-query-string-from-location
branch
from
5a576f9
to
aefae1e
Compare
rspeicher
pushed a commit
to gitlabhq/gitlabhq
that referenced
this pull request
Mar 22, 2018
|
FYI, this was necessary to mitigate https://about.gitlab.com/2018/03/26/summary-of-limited-gitlab-credentials-exposed. |
|
Thanks! |
mayra-cabrera
pushed a commit
to gitlabhq/gitlabhq
that referenced
this pull request
Apr 30, 2018
lograge 0.10.0 contains the `Location` query string fix in roidrage/lograge#241 among other minor changes: https://github.com/roidrage/lograge/blob/master/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Location URL may contain sensitive information, so just like the path
we should remove the query string.
Closes #229