Use a dedicated ActiveSupport::Deprecation #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxlpnk
approved these changes
Apr 21, 2023
Rails 7.1 will deprecate using the singleton ActiveSupport::Deprecation instance (rails/rails#47354). This defines one for the gem and uses it. It's also added to the application's set of deprecators, allowing it to be configured along all the other deprecators.
etiennebarrie
force-pushed
the
deprecator
branch
from
f3b5fef
to
bc5ef25
Compare
|
I just saw this had merge conflicts with main and I rebased. Rails 7.1 is just around the corner (the first release candidate was published), so if we could get this merged and released, it would be great to avoid deprecation warnings for all users of this gem under Rails 7.1. Let me know if there's anything I can do to help! |
|
With Rails 7.1 released it would be great to get this PR merged and a new release of lograge published. How can I help? |
|
Hey folks, apologies for the lack of involvement from me on this. I'll get this merged and cut a release in a mo! Thanks for helping out. |
|
Thank you! No worries, you have no obligations towards us. We really appreciate all the time and effort you put into this. |
|
0.14.0 is in rubygems 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1 will deprecate using the singleton ActiveSupport::Deprecation instance (rails/rails#47354). This defines one for the gem and uses it.
It's also added to the application's set of deprecators, allowing it to be configured along all the other deprecators.